Lemon-miaow
508a1c02da
A server whose world PVC does not exist yet (never started) or no longer exists (the world was already reaped) accepted the backup/restore POST, answered 202, and the Job sat Pending on the missing claim until its deadline with nothing recorded anywhere — a silent no-op from the operator's seat. The live drill on the reaped `resolvecheck` world reproduced exactly that. Both handlers now read the world PVC (Cluster.WorldVolumeExists, over the same naming.WorldPVCName the Jobs mount) and answer a specific 409 no_world_volume with "start it once to create it, then retry". The felis-api Role gains the matching get-only PVC grant — the first live run surfaced the missing RBAC as a 403 behind a 500, so the fix ships with it. Live (auditfix38): resolvecheck -> 409 no_world_volume on both faces; test-one (which has a world) still backs up through the new gate end to end.
108 lines
5.4 KiB
Go
108 lines
5.4 KiB
Go
package api
|
|
|
|
import (
|
|
"context"
|
|
|
|
"felis.lolicon.best/internal/apis/felis/v1alpha1"
|
|
corev1 "k8s.io/api/core/v1"
|
|
)
|
|
|
|
// ServerInfo is the lifecycle view read from the MinecraftServer CRD + status
|
|
// (spec §4). The CRD is the source-of-truth; the API mutates its spec only via
|
|
// the app-tier desiredState lever (wake/stop, spec §9.1) and the admin-tier spec
|
|
// patch (spec §7 PATCH /servers/{name}) — never the business-layer fields, which
|
|
// live in Postgres (spec §22).
|
|
type ServerInfo struct {
|
|
Name string `json:"name"`
|
|
Subdomain string `json:"subdomain"`
|
|
Phase string `json:"phase"`
|
|
Ready bool `json:"ready"`
|
|
AutostartPolicy string `json:"autostartPolicy,omitempty"`
|
|
DesiredState string `json:"desiredState,omitempty"`
|
|
EndpointMode string `json:"endpointMode,omitempty"`
|
|
EndpointAddress string `json:"endpointAddress,omitempty"`
|
|
PlayersOnline int32 `json:"playersOnline"`
|
|
PlayersMax int32 `json:"playersMax"`
|
|
DisplayName string `json:"displayName,omitempty"`
|
|
Image string `json:"image,omitempty"`
|
|
JavaMemory string `json:"javaMemory,omitempty"`
|
|
StorageSize string `json:"storageSize,omitempty"`
|
|
CPU string `json:"cpu,omitempty"`
|
|
}
|
|
|
|
// CreateServerInput is the validated, structured create-server form (spec §15).
|
|
// felis-api has already enforced naming, reservation, image whitelist, quota
|
|
// policy, and the §22 memory ceiling before this reaches the cluster: there is
|
|
// no free-form YAML path — every field is a typed, validated value. A created
|
|
// server starts DesiredState=Stopped and unowned (claimed later, spec §9.3).
|
|
type CreateServerInput struct {
|
|
Name string
|
|
Subdomain string
|
|
DisplayName string
|
|
Image string
|
|
JavaMemory string
|
|
StorageSize string
|
|
AutostartPolicy v1alpha1.AutostartPolicy
|
|
// Resources is the fully-resolved pod resource block. Its memory limit is the
|
|
// §22 ceiling — felis-api guarantees it is non-zero (the operator does not
|
|
// derive a cgroup limit from JavaMemory).
|
|
Resources corev1.ResourceRequirements
|
|
}
|
|
|
|
// ServerSpecPatch is the resolved, validated set of admin-tier mutations applied
|
|
// to one MinecraftServer spec (spec §7 PATCH /servers/{name}). felis-api has
|
|
// already validated naming, admitted any new image against the whitelist, parsed
|
|
// the policy, and derived the §22 memory ceiling before this reaches the cluster:
|
|
// there is no free-form YAML path. Every field is a pointer — nil means "leave
|
|
// unchanged", so the patch touches only the fields the admin explicitly set. It
|
|
// deliberately omits the dual-write routing identity (subdomain, the object name)
|
|
// and the world PVC size, which felis-api rejects before constructing this so the
|
|
// CRD and Postgres never desync (spec §22).
|
|
type ServerSpecPatch struct {
|
|
DisplayName *string
|
|
AutostartPolicy *v1alpha1.AutostartPolicy
|
|
Image *string
|
|
// JavaMemory is the re-derived JVM heap string; Resources carries the matching
|
|
// pod block whose memory limit is the non-zero §22 ceiling. They move together
|
|
// (felis-api resolves both from the same form) or both stay nil.
|
|
JavaMemory *string
|
|
Resources *corev1.ResourceRequirements
|
|
}
|
|
|
|
// Cluster is the lifecycle-layer access the API depends on: reads of the
|
|
// MinecraftServer CRD, the app-tier desiredState lever (spec §9.1), the admin-tier
|
|
// create (spec §15), and the admin-tier spec patch (spec §7). It is an interface
|
|
// so handlers are tested against a fake; the controller-runtime implementation
|
|
// (k8sCluster) is integration-tested only — it requires a live cluster.
|
|
type Cluster interface {
|
|
// Ping verifies the K8s API and CRD informer are healthy — used by /readyz
|
|
// (spec §7) to confirm the lifecycle store is reachable and synced.
|
|
Ping(ctx context.Context) error
|
|
|
|
// GetServer reads one MinecraftServer's lifecycle view, or ErrNotFound.
|
|
GetServer(ctx context.Context, name string) (*ServerInfo, error)
|
|
// WorldVolumeExists reports whether the server's world PVC exists in the
|
|
// server namespace. A server that never started — or whose world the
|
|
// retention reaper already archived and deleted — has no claim, and a
|
|
// backup/restore Job would hang Pending on the missing volume with nothing
|
|
// ever recorded, so both handlers refuse those up front.
|
|
WorldVolumeExists(ctx context.Context, name string) (bool, error)
|
|
// GetBySubdomain finds the MinecraftServer whose spec.subdomain matches, or
|
|
// ErrNotFound.
|
|
GetBySubdomain(ctx context.Context, subdomain string) (*ServerInfo, error)
|
|
// ListServers returns the lifecycle view of every MinecraftServer, for the
|
|
// velocity registration pull (spec §7 GET /servers).
|
|
ListServers(ctx context.Context) ([]ServerInfo, error)
|
|
// SetDesiredState flips spec.desiredState — the only write the API performs
|
|
// against the CRD (spec §9.1). It is idempotent.
|
|
SetDesiredState(ctx context.Context, name string, state v1alpha1.DesiredState) error
|
|
// CreateServer creates a MinecraftServer CRD from the validated form (spec
|
|
// §15). It returns ErrConflict if a server of that name already exists.
|
|
CreateServer(ctx context.Context, in CreateServerInput) error
|
|
// PatchServerSpec applies an admin-tier spec mutation (spec §7 PATCH
|
|
// /servers/{name}): only the non-nil fields of the patch are written, via a
|
|
// merge patch so a concurrent operator status write is never clobbered. It
|
|
// returns ErrNotFound if no server of that name exists.
|
|
PatchServerSpec(ctx context.Context, name string, patch ServerSpecPatch) error
|
|
}
|