flyemoji
80a29ba653
The panel has a full permission surface — internal/api/handlers_access.go issues
`lp user <player> permission set/unset` and `lp user <player> parent add/remove`
over RCON, and projects the result back at
GET /api/v1/servers/{name}/access/luckperms/{player} — but nothing in this tree
ever installed LuckPerms. The lobby image copied felis-paper.jar into the plugin
directory and stopped there, so every grant the panel sent reached a server that
answered "Unknown command". Confirmed on the demo host: /data/plugins held only
FelisPaper/, bStats/, felis-paper.jar and spark/.
This is the other half of the RCON change. That one gave the control plane a
channel to send commands on; this one puts something at the far end that
understands them. Neither is useful alone.
The jar is resolved at build time rather than pinned in the Dockerfile, the same
way PAPER_JAR_URL already is: metadata.luckperms.net publishes the current build
for every platform, and asking upstream keeps this tree from going stale on every
LuckPerms release. Unlike Paper it is not version-matched to MC_VERSION — LuckPerms
ships one Bukkit build covering the whole supported Minecraft range, so there is no
per-version endpoint to ask. The resolver's pattern pins the /bukkit/loader/ path
segment deliberately: the metadata endpoint hands back the fabric, forge, velocity
and bukkit-legacy URLs in the same payload, and a looser match would happily return
a jar Paper cannot load, or the legacy build that targets Minecraft 1.8-1.12.
A missing LUCKPERMS_JAR_URL fails the build. That is a harsher default than the
RCON password, which only warns, and the difference is where the failure surfaces:
a lobby without RCON degrades visibly at once, whereas a lobby without LuckPerms
starts perfectly, runs perfectly, and only reveals itself when an owner tries to
grant somebody a permission. Build time is the cheap place to notice.
The entrypoint refreshes the jar from the image seed on every boot exactly as it
does for paper.jar and felis-paper.jar, so the executable artifact tracks the image
while LuckPerms' H2 database and config under plugins/LuckPerms/ stay on the PVC.
That split is the point: every grant ever issued lives in that directory, so the
refresh must never become a wipe.
Check: the three files that have to agree about LuckPerms — bootstrap.sh resolving
and passing the build-arg, the Dockerfile requiring that arg name and writing a
fixed path, the entrypoint copying from that same path — are pinned against each
other. Nothing compiles them together, and a typo in the path is invisible until a
lobby boots and `set -e` turns the failed cp into a crashloop on the hub every
authenticated player is transferred to. The test reads all three back out of the
embedded FS rather than off disk, since that is what the TUI install path ships.
Deployed installs are NOT fixed by this commit, for the same reason the RCON change
was not: the felis-lobby image has to be rebuilt and re-imported, and the pods
recreated, before the jar exists on the volume.
75 lines
3.3 KiB
Go
75 lines
3.3 KiB
Go
package felis
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// The lobby's LuckPerms wiring is a three-file contract with no compiler behind it:
|
|
// bootstrap.sh resolves a URL and passes it as a build-arg, the Dockerfile requires
|
|
// that exact arg name and writes the jar to a fixed path, and entrypoint.sh copies
|
|
// from that same path on every boot. A typo in any one of them is invisible until a
|
|
// lobby actually starts — and then `set -e` turns the failed cp into a crashloop on
|
|
// the always-on hub every authenticated player is transferred to.
|
|
//
|
|
// All three files ship inside the binary (gameStackAssets, bootstrapScript) for the
|
|
// TUI install path that has no source checkout, so reading them back here checks
|
|
// what is actually shipped rather than what is merely on disk.
|
|
func TestLobbyLuckPermsWiringIsConsistent(t *testing.T) {
|
|
dockerfile := readGameStackFile(t, "deploy/lobby/Dockerfile")
|
|
entrypoint := readGameStackFile(t, "deploy/lobby/entrypoint.sh")
|
|
script := BootstrapScript()
|
|
|
|
// The path is the contract. RUNTIME_DIR is /paper in the entrypoint, so the
|
|
// Dockerfile's download target and the boot-time copy source must be the same
|
|
// string; anything else fails at `cp`, not at build.
|
|
const jarPath = "/paper/plugins/LuckPerms.jar"
|
|
if !strings.Contains(dockerfile, "-o "+jarPath) {
|
|
t.Errorf("Dockerfile does not download LuckPerms to %s", jarPath)
|
|
}
|
|
if !strings.Contains(entrypoint, `cp -f "$RUNTIME_DIR/plugins/LuckPerms.jar"`) {
|
|
t.Error("entrypoint.sh does not refresh LuckPerms.jar from the image seed; " +
|
|
"a lobby would keep whatever stale jar the PVC happens to hold")
|
|
}
|
|
if !strings.Contains(entrypoint, `RUNTIME_DIR="/paper"`) {
|
|
t.Error(`RUNTIME_DIR is no longer "/paper", so the copy above no longer ` +
|
|
"resolves to the path the Dockerfile writes")
|
|
}
|
|
|
|
// The build-arg name has to agree across the two files that never see each other.
|
|
const arg = "LUCKPERMS_JAR_URL"
|
|
if !strings.Contains(dockerfile, "ARG "+arg) {
|
|
t.Errorf("Dockerfile declares no ARG %s", arg)
|
|
}
|
|
if !strings.Contains(script, "--build-arg "+arg+"=") {
|
|
t.Errorf("bootstrap.sh never passes --build-arg %s", arg)
|
|
}
|
|
if !strings.Contains(script, "LUCKPERMS_JAR_URL=\"$(luckperms_latest_jar)\"") {
|
|
t.Error("bootstrap.sh does not resolve the LuckPerms URL before building")
|
|
}
|
|
|
|
// bukkit-legacy targets Minecraft 1.8-1.12 and the other platforms are not
|
|
// loadable by Paper at all, so the resolver's grep must pin the /bukkit/ path
|
|
// segment — the metadata endpoint returns every platform's URL in one payload.
|
|
if !strings.Contains(script, "/bukkit/loader/") {
|
|
t.Error("luckperms_latest_jar does not pin the bukkit/loader path; it could " +
|
|
"return the fabric, forge or velocity jar, none of which Paper can load")
|
|
}
|
|
|
|
// A missing jar must stop the build. The alternative — shipping a lobby that
|
|
// starts fine and answers every `lp` command from the panel's permission screen
|
|
// with "Unknown command" — is discovered in production.
|
|
if !strings.Contains(dockerfile, `if [ -z "${LUCKPERMS_JAR_URL:-}" ]`) {
|
|
t.Error("Dockerfile does not fail the build when LUCKPERMS_JAR_URL is unset")
|
|
}
|
|
}
|
|
|
|
func readGameStackFile(t *testing.T, name string) string {
|
|
t.Helper()
|
|
b, err := gameStackAssets.ReadFile(name)
|
|
if err != nil {
|
|
t.Fatalf("read embedded %s: %v", name, err)
|
|
}
|
|
return string(b)
|
|
}
|