Lemon-miaow
36b954d347
The comment described a deterministic-name collision that the unique random suffix made near-impossible; align it with Backuper.Backup and jobspec's contract (ErrAlreadyExists survives only as the defensive no-op).
44 lines
1.5 KiB
Go
44 lines
1.5 KiB
Go
package backupjob
|
|
|
|
import (
|
|
"context"
|
|
|
|
apierrors "k8s.io/apimachinery/pkg/api/errors"
|
|
"sigs.k8s.io/controller-runtime/pkg/client"
|
|
)
|
|
|
|
// K8sJobs is the production Jobs backed by a controller-runtime client. It creates
|
|
// the on-demand world-backup Job — nothing more: the backup Job is one-shot and
|
|
// self-cleaning (ttlSecondsAfterFinished), so there is no phase or cancel seam, and
|
|
// thus no config to hold. Every backup parameter arrives in the JobParams the
|
|
// Backuper builds from its own (defaulted) Config. The cluster-bootstrap objects
|
|
// (the weak felis-restore SA it reuses) are installed once by the deployment
|
|
// manifests, not per backup, so this binding never creates them. It is
|
|
// integration-tested against a live cluster, not the hermetic unit suite.
|
|
type K8sJobs struct {
|
|
c client.Client
|
|
}
|
|
|
|
// NewK8sJobs builds a Jobs over c.
|
|
func NewK8sJobs(c client.Client) *K8sJobs {
|
|
return &K8sJobs{c: c}
|
|
}
|
|
|
|
// CreateBackupJob renders and applies the backup Job. Its name carries a fresh
|
|
// random suffix (see Backuper.Backup), so a repeated backup never collides with a
|
|
// just-finished Job inside its TTL window; ErrAlreadyExists survives only as the
|
|
// defensive no-op for the astronomically unlikely suffix collision.
|
|
func (k *K8sJobs) CreateBackupJob(ctx context.Context, p JobParams) error {
|
|
job, err := BackupJob(p)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if err := k.c.Create(ctx, job); err != nil {
|
|
if apierrors.IsAlreadyExists(err) {
|
|
return ErrAlreadyExists
|
|
}
|
|
return err
|
|
}
|
|
return nil
|
|
}
|