fix(panel): 本人与所有者账户的禁用和删除按钮提前锁定并说明原因,角色改为只读,后端拒绝改用专用错误码 self_protected 与 owner_protected
This commit is contained in:
13 files changed
+269
-27
No files matched your search
@@ -25,19 +25,49 @@ func TestOwnerAccountProtectedFromPanelMutations(t *testing.T) {
|
||||
if w.Code != http.StatusForbidden {
|
||||
t.Fatalf("demote owner: code = %d body %s, want 403", w.Code, w.Body.String())
|
||||
}
|
||||
if got := decodeErr(t, w); got != "owner_protected" {
|
||||
t.Fatalf("demote owner: error code = %q, want owner_protected", got)
|
||||
}
|
||||
})
|
||||
t.Run("delete refused", func(t *testing.T) {
|
||||
w := do(eh, "DELETE", "/api/v1/users/usr-owner2", "", nil)
|
||||
if w.Code != http.StatusForbidden {
|
||||
t.Fatalf("delete owner: code = %d body %s, want 403", w.Code, w.Body.String())
|
||||
}
|
||||
if got := decodeErr(t, w); got != "owner_protected" {
|
||||
t.Fatalf("delete owner: error code = %q, want owner_protected", got)
|
||||
}
|
||||
})
|
||||
t.Run("disable refused", func(t *testing.T) {
|
||||
w := do(eh, "POST", "/api/v1/users/usr-owner2/disable", `{"disabled":true}`, jsonHeader)
|
||||
if w.Code != http.StatusForbidden {
|
||||
t.Fatalf("disable owner: code = %d body %s, want 403", w.Code, w.Body.String())
|
||||
}
|
||||
if got := decodeErr(t, w); got != "owner_protected" {
|
||||
t.Fatalf("disable owner: error code = %q, want owner_protected", got)
|
||||
}
|
||||
})
|
||||
// The caller's own row is refused as self_protected even though it is also
|
||||
// an owner: that is the reason the admin can act on.
|
||||
for _, tc := range []struct{ name, method, path, body string }{
|
||||
{"own role", "PATCH", "/api/v1/users/usr-root", `{"role":"admin"}`},
|
||||
{"own delete", "DELETE", "/api/v1/users/usr-root", ""},
|
||||
{"own disable", "POST", "/api/v1/users/usr-root/disable", `{"disabled":true}`},
|
||||
} {
|
||||
t.Run(tc.name+" refused as self", func(t *testing.T) {
|
||||
var h map[string]string
|
||||
if tc.body != "" {
|
||||
h = jsonHeader
|
||||
}
|
||||
w := do(eh, tc.method, tc.path, tc.body, h)
|
||||
if w.Code != http.StatusForbidden {
|
||||
t.Fatalf("code = %d body %s, want 403", w.Code, w.Body.String())
|
||||
}
|
||||
if got := decodeErr(t, w); got != "self_protected" {
|
||||
t.Fatalf("error code = %q, want self_protected", got)
|
||||
}
|
||||
})
|
||||
}
|
||||
t.Run("email edits on an owner stay allowed", func(t *testing.T) {
|
||||
w := do(eh, "PATCH", "/api/v1/users/usr-owner2", `{"email":"[email protected]"}`, jsonHeader)
|
||||
if w.Code != http.StatusOK {
|
||||
|
||||
Reference in new issue
Block a user