feat(updater): authenticate GitHub polling and track the real release repo
felis-api's coord was the placeholder "felis/felis", which resolves against nothing on real GitHub. It is now MliroLirrorsIngenuity/Felis — the same slug deploy/bootstrap.sh clones from — so update reporting for the control plane itself is live rather than parked. That repo is private today, so the github source gained an optional token, read from FELIS_GITHUB_TOKEN: the variable bootstrap already needs, so an operator sets one value once. It comes from the environment and is never compiled in. A constant would be committed to the very repository it protects, ship inside every felis binary where strings(1) recovers it, reach every node the image is imported onto, and need a rebuild and a redeploy to rotate. Empty stays the correct posture for the other tracked components — k3s and cloudflared are public — and an empty token sends no Authorization header at all rather than an empty one. GitHub answers 404, not 401 or 403, for a private repo the caller cannot see, so "no token" and "no stable release published yet" arrive as the same status. On an unauthenticated 404 the error now names both causes and the variable that fixes the actionable one. With a token already set that hint would be wrong, so it is suppressed. Tests pin both halves: the Bearer header is sent only when the token is set, and the diagnostic names the variable only when it is not. doc.go's CAVEATS bullet still described the coord as a placeholder and the component as "dark at runtime". Both were true only until this change; it now records the real condition, which is that the component resolves like the others but needs a credential while the repo is private.
This commit is contained in:
6 files changed
+110
-14
No files matched your search
@@ -47,10 +47,12 @@ type Spec struct {
|
||||
// pin — there is no policy path by which Topology can propose changing it.
|
||||
func Topology() []Spec {
|
||||
return []Spec{
|
||||
// Coord "felis/felis" is a placeholder for the operator's own release repo: the
|
||||
// GitHub source now consumes it, so the routing/parse path is live, but it will
|
||||
// not resolve against real GitHub until the operator's actual repo slug is set.
|
||||
{Name: "felis-api", Policy: updates.PolicyScheduled, Manageable: true, Source: sourceGitHub, Coord: "felis/felis"},
|
||||
// Felis's own release repo, and the same slug deploy/bootstrap.sh clones from
|
||||
// (FELIS_REPO_URL). It is PRIVATE today, which is why the github source carries an
|
||||
// optional token: unauthenticated, this coord answers 404 — the status GitHub uses
|
||||
// to hide a repo's existence — and felis-api is the one tracked component where
|
||||
// that happens. k3s and cloudflared are public and need no credential.
|
||||
{Name: "felis-api", Policy: updates.PolicyScheduled, Manageable: true, Source: sourceGitHub, Coord: "MliroLirrorsIngenuity/Felis"},
|
||||
{Name: "k3s", Policy: updates.PolicyNotify, Manageable: false, Source: sourceGitHub, Coord: "k3s-io/k3s"},
|
||||
{Name: "cloudflared", Policy: updates.PolicyScheduled, Manageable: true, Source: sourceGitHub, Coord: "cloudflare/cloudflared"},
|
||||
{Name: "velocity", Policy: updates.PolicyNotify, Manageable: false, Source: sourcePaperMC, Coord: "velocity"},
|
||||
|
||||
Reference in new issue
Block a user