Unverified Commit c14ed170 authored by Minseong Choi's avatar Minseong Choi 💬
Browse files

fix(docker): keep embedded panel/ and deploy/ in the image build context 

`docker build` failed twice over because .dockerignore excluded two trees the
image actually needs. The panel stage's `COPY panel/ ./` hit `"/panel": not
found`, and even past that the Go build would fail: the root felis package
//go:embeds deploy/bootstrap.sh and deploy/crd/*.yaml, which `COPY . .` dropped
along with the excluded deploy/.

The stale header comment claimed only internal/store/migrations was embedded,
which is what licensed the over-broad exclusions. Rewrite it to name all three
embedded trees (migrations, deploy assets, panel static) and warn against
re-adding panel/, deploy/, or internal/ without re-checking the go:embed list.

Tighten node_modules -> **/node_modules so a working-tree build no longer drags
panel/node_modules over the Linux modules npm ci installs in the panel stage.
parent eb5875a6

.dockerignore

+7 −7
Changes for .dockerignore: 7 added lines, 7 removed lines.
Original line number Diff line number Diff line 
# Keep the felis image build context tiny: the binary is pure Go (only

# internal/store/migrations/*.sql is embedded), so none of the web/plugin/doc

# assets are needed and shipping them would bloat the context and slow `docker

# build` on a small host.

# Keep the felis image build context lean, but mind the embeds: three trees MUST

# stay in the context or the image build fails. internal/store/migrations/*.sql,

# deploy/bootstrap.sh and deploy/crd/*.yaml are //go:embed-ed by Go packages the

# binary compiles, and internal/panel/static is the panel the Dockerfile panel

# stage builds from panel/. Exclude only build-irrelevant trees below; never add

# panel/, deploy/, or internal/ here without checking `grep -rn go:embed`.

.git

.claude

node_modules

panel

**/node_modules

plugins

docs

*.md

deploy

Dockerfile

.dockerignore

.gitignore