Unverified Commit c0ee75ef authored by Minseong Choi's avatar Minseong Choi 💬
Browse files

fix(panel): mark the webview acknowledgement cookie secure

parent 118e3bc0

internal/panel/webview.go

+1 −0
Changes for internal/panel/webview.go: 1 added line, 0 removed lines.
Original line number Diff line number Diff line
@@ -75,6 +75,7 @@ func guardInAppWebView(w http.ResponseWriter, r *http.Request) bool { 
			Value:    "1",

			Path:     "/",

			HttpOnly: true,

			Secure:   true,

			SameSite: http.SameSiteLaxMode,

			MaxAge:   3600,

		})

internal/panel/webview_test.go

+2 −2
Changes for internal/panel/webview_test.go: 2 added lines, 2 removed lines.
Original line number Diff line number Diff line
@@ -138,12 +138,12 @@ func TestGuardHonorsAcknowledgement(t *testing.T) { 
	}

	var acked bool

	for _, c := range w.Result().Cookies() {

		if c.Name == webViewAckCookie && c.Value == "1" {

		if c.Name == webViewAckCookie && c.Value == "1" && c.Secure {

			acked = true

		}

	}

	if !acked {

		t.Fatalf("ua_ack did not set the ack cookie")

		t.Fatalf("ua_ack did not set a Secure ack cookie")

	}



	// A subsequent navigation carrying the ack cookie is not interrupted.