From 3327c13429ee356a3e506db3e79c8e5416cc60d8 Mon Sep 17 00:00:00 2001
From: Lemon-miaow <admin@lemonmiaow.xyz>
Date: Wed, 7 Oct 2026 03:07:35 +0800
Subject: [PATCH] fix: register canonical SELinux socket path and pass
 staticcheck

---
 cmd/felis/node_control.go |  4 ++--
 deploy/bootstrap.sh       |  5 +++--
 deploy/bootstrap_test.sh  | 22 ++++++++++++++++++++++
 3 files changed, 27 insertions(+), 4 deletions(-)

diff --git a/cmd/felis/node_control.go b/cmd/felis/node_control.go
index bbe8df7..2bab33a 100644
--- a/cmd/felis/node_control.go
+++ b/cmd/felis/node_control.go
@@ -172,7 +172,7 @@ func (e nodeExecutor) run(ctx context.Context, r nodecontrol.Request, stage func
 		return err
 	}
 	if len(deployment.Spec.Template.Spec.Containers) == 0 {
-		return errors.New("Felis API image is unavailable")
+		return errors.New("the Felis API image is unavailable")
 	}
 	image := deployment.Spec.Template.Spec.Containers[0].Image
 	if r.Action == "enable" {
@@ -301,7 +301,7 @@ func (e nodeExecutor) requireStopped(ctx context.Context, r nodecontrol.Request)
 			continue
 		}
 		if p.Status.Phase != corev1.PodSucceeded && p.Status.Phase != corev1.PodFailed {
-			return fmt.Errorf("Pod %s has not exited (phase %s); wait for game and maintenance workloads to stop", p.Name, p.Status.Phase)
+			return fmt.Errorf("pod %s has not exited (phase %s); wait for game and maintenance workloads to stop", p.Name, p.Status.Phase)
 		}
 	}
 	// Prevent a pending wake intent racing admission or an installation.
diff --git a/deploy/bootstrap.sh b/deploy/bootstrap.sh
index 4222124..72be069 100644
--- a/deploy/bootstrap.sh
+++ b/deploy/bootstrap.sh
@@ -5238,8 +5238,9 @@ EOF_NODE_SELINUX
 d /run/felis-node-control 0750 root 65532 -
 EOF_NODE_TMP
   if [ -n "$selinux_environment" ] && command -v semanage >/dev/null 2>&1; then
-    semanage fcontext -a -t felis_node_control_socket_t '/run/felis-node-control(/.*)?' 2>/dev/null \
-      || semanage fcontext -m -t felis_node_control_socket_t '/run/felis-node-control(/.*)?'
+    # /run is an SELinux equivalence alias for /var/run. Register the canonical path.
+    semanage fcontext -a -t felis_node_control_socket_t '/var/run/felis-node-control(/.*)?' 2>/dev/null \
+      || semanage fcontext -m -t felis_node_control_socket_t '/var/run/felis-node-control(/.*)?'
   fi
   if [ -n "$selinux_environment" ] && command -v chcon >/dev/null 2>&1; then
     chcon -R -t felis_node_control_socket_t /run/felis-node-control 2>/dev/null || true
diff --git a/deploy/bootstrap_test.sh b/deploy/bootstrap_test.sh
index 827023c..750a803 100644
--- a/deploy/bootstrap_test.sh
+++ b/deploy/bootstrap_test.sh
@@ -5316,6 +5316,28 @@ out="$(WORKER_TOKEN_FILE="$badtoken" bash -c '
 expect "worker refuses a copied server token before changing the machine" 'worker accepts only CA-pinned bootstrap tokens' "$out"
 rm -f "$badtoken"
 
+# SELinux rejects /run paths when the policy aliases them to /var/run.
+node_fcontext="$(bsfn install_node_control_service | awk '/^  if .*command -v semanage/,/^  fi/')"
+[ -n "$node_fcontext" ] && [ "$(printf '%s\n' "$node_fcontext" | wc -l)" -lt 12 ] \
+  || { echo "FAIL: node-control fcontext block could not be extracted"; exit 1; }
+for existing in 0 1; do
+  out="$(EXISTING="$existing" bash -c '
+    selinux_environment=enabled
+    semanage() {
+      case "$5" in /run/felis-node-control*) echo "alias conflict"; return 1;; esac
+      echo "$*"
+      [ "$EXISTING" != 1 ] || [ "$2" = -m ]
+    }
+    '"$node_fcontext"
+  )"
+  expect "node-control registers the canonical SELinux path ($existing)" \
+    "fcontext -a -t felis_node_control_socket_t /var/run/felis-node-control(/.*)?" "$out"
+  if [ "$existing" = 1 ]; then
+    expect "node-control updates an existing canonical rule" \
+      "fcontext -m -t felis_node_control_socket_t /var/run/felis-node-control(/.*)?" "$out"
+  fi
+done
+
 # ---------------------------------------------------------------------------------------
 if [ "$fails" -eq 0 ]; then
   echo "ALL PASS"